Skip to content

Fix continuous integration by ignoring some more urls #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

b-studios
Copy link
Contributor

Continuous integration is broken because of two reasons:

  1. Twitter API responds with 400 which indicates missing permission
  2. Some API links generated by the Scala 3 doctool are currently not available

This PR addresses both by ignoring 400 status errors and ignoring the missing doctool url (temporarily).

As per twitter's API description, 400 indicates an authentication problem.
I am not trying to fix the underlying problem here, but merely ignore the
error.
@b-studios b-studios requested a review from julienrf January 4, 2021 11:41
@b-studios
Copy link
Contributor Author

Strange... ignoring did the trick for me locally. I'll try ignore-file on the conflicting file instead.

@b-studios
Copy link
Contributor Author

Ok, I changed the ignore pattern and we are now good to go.

@b-studios b-studios changed the title Fix CI Fix continuous integration by ignoring some more urls Jan 4, 2021
@b-studios b-studios requested a review from SethTisue January 4, 2021 13:08
@SethTisue SethTisue merged commit 1bdf5a4 into scala:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants